medblocks / medblocks-ui

Web Components Library for Medblocks Ecosystem
https://www.npmjs.com/package/medblocks-ui
Apache License 2.0
54 stars 15 forks source link

issue with @sholace package in google chrome (v114.0.5735.133) #51

Closed ardihikaru closed 1 year ago

ardihikaru commented 1 year ago

Hi. I have a problem with @shoelace-style/shoelace package when opening my web app in Google Chrome: image image

reposition() {
            this.open && this.popover.update()  ----> this one
        }
        async handleOpenChange() {
            if (!this.disabled)
                if (this.updateAccessibleTrigger(),
                this.open) {
                    Ybe(this, "sl-show"),
                    this.panel.addEventListener("sl-activate", this.handleMenuItemActivate),
                    this.panel.addEventListener("sl-select", this.handlePanelSelect),
                    document.addEventListener("keydown", this.handleDocumentKeyDown),
                    document.addEventListener("mousedown", this.handleDocumentMouseDown),
                    await Obe(this),
                    this.popover.update(),  ----> this one
                    this.panel.hidden = !1;
                    const {keyframes: e, options: t} = Kbe(this, "dropdown.show");

It only happens in Google Chrome version 114.0.5735.133. Tried to forcefully increase the version to ^2.4.0, but the problem persists.

Any solution for this issue?

Thanks, Ardi

sidharthramesh commented 1 year ago

This has been fixed in the latest version of Medblocks ui. You’ll need to use it with shoelace version 2.0.0-beta.71.

JokoHadi commented 1 year ago

I have same issue for this one my google chrome version is 114.0.5735.134

I've updated medblock-ui to the latest version (0.0.179), and it seems to be using "@shoelace-style/shoelace": "2.0.0-beta.71" But I still get same errors

Did I miss something?

sidharthramesh commented 1 year ago

Do you have a repo with the minimal code to reproduce this issue?

sidharthramesh commented 1 year ago

@ATHULKNAIR FYI

ardihikaru commented 1 year ago

Hi, thanks for the solution. I updated the version as mentioned and managed to solve it. here is the update on the package.json:

  "devDependencies": {
    ...
    "svelte": "^3.59.1",
    ...
  "dependencies": {
    ...
    "@shoelace-style/shoelace": "^2.0.0-beta.71",
    "medblocks-ui": "^0.0.179",

and also, in case anyone faces the same issue, please do not forget to delete your old package-lock.json file, if this does not solve your problem.

So, I will close this issue. Many thanks.