search

medenagan / window-corner-preview

GNOME Shell extension showing a video preview on the corner of the screen
https://extensions.gnome.org/extension/1227/window-corner-preview/
MIT License
135 stars 26 forks source link

gnome-shell 3.36.1 compatibility #23

Open jcarle opened 4 years ago

jcarle commented 4 years ago

I have tried to fix the errors that occur in gnome-shell 3.36.1 Please check if it's ok.

Thank you

RandieM commented 4 years ago

It works on Fedora 32/Gnome 3.36.2.

nicjohnston commented 3 years ago

Unfortunately this stopped working with Gnome 3.36.4 on Debian testing. The extension loads, and seems to allow window selection, but doesn't display anything. Checking the logs shows the following error message being generated when selecting a window to preview.

gnome-shell[3009]: JS ERROR: TypeError: this._container.foreach is not a function
    _setThumbnail@/home/nic/.local/share/gnome-shell/extensions/window-corner-preview@fabiomereu.it/preview.js:410:25
    set window@/home/nic/.local/share/gnome-shell/extensions/window-corner-preview@fabiomereu.it/preview.js:633:14
    _onUserTriggered/</</<@/home/nic/.local/share/gnome-shell/extensions/window-corner-preview@fabiomereu.it/indicator.js:141:21
    activate@resource:///org/gnome/shell/ui/popupMenu.js:191:14
    vfunc_button_release_event@resource:///org/gnome/shell/ui/popupMenu.js:138:14