search

medfreeman / markdown-it-toc-and-anchor

markdown-it plugin to add a toc and anchor links in headings
MIT License
60 stars 35 forks source link

Support unicode heading and GitHub style anchor link #6

Closed tylerlong closed 8 years ago

tylerlong commented 8 years ago

Fixed:

  1. https://github.com/MoOx/markdown-it-toc-and-anchor/issues/3
  2. https://github.com/MoOx/markdown-it-toc-and-anchor/issues/5
MoOx commented 8 years ago

Except my comment, this looks good! Could you squash the first 5 commits?

tylerlong commented 8 years ago

Let me have a try. I have never tried git squash

MoOx commented 8 years ago

Use git rebase -i.

MoOx commented 8 years ago

Then you will need to git push --force your branch.

tylerlong commented 8 years ago

done

tylerlong commented 8 years ago

@MoOx ping. Let me know if you want me to do any other improvements before you can merge it. Thanks.

MoOx commented 8 years ago

Sorry for the delay. I am going to a conference this week and would like to fix CI before merging this. Be sure that I will merge this as soon as I can ! Thanks.

tylerlong commented 8 years ago

Good to know. I also made several other changes. I will send more PRs after you merge this one. No hurry and take your time!

MoOx commented 8 years ago

Merging, I will fix the CI issue.

MoOx commented 8 years ago

Released as 2.1.0. I made some update to babel, eslint and the test runner. Feel free to ask if you have any question about that.