search

medhatelmasry / GoodBooks

Accounting System built in ASP.NET DotNetCore, ReactJS, MobX. Don't forget to click STAR if you like this project.
http://accountgo.net
MIT License
6 stars 0 forks source link

Financials >> Taxes #11

Open medhatelmasry opened 6 months ago

medhatelmasry commented 6 months ago

There are clickable columns on this page but appear to do nothing.

ydongchoi commented 4 months ago

I think it's a script src problem. because we don't have knockout.js file in specific path of script tag. So, I just added jquery, bootstrap src. and then, it solved.

Action

image

Result

image

Next

what should we use src? because, we will upgrade ui using blazor.

medhatelmasry commented 4 months ago

Great that you got it working with jQuery. Let us go with it because, at the moment, I just want everything to work. The longer term plan to change everything to Blazor. This is perfect for this moment. Go ahead and push your code and make a pull request.

ydongchoi commented 4 months ago

I think the solution above is temporary. when i look closely at the code, there is probelm about bootstrap.min.js in _Layout_bootstrap.cshtml.

Solution

boostrap version 3.2.0 works. but anther version does not work.

  1. Works.
  2. Not Works
medhatelmasry commented 4 months ago

This issue is related to issue 26, which suggests that we convert this page to Blazor. As it stands, we either made the various tabs do something with the current technology (knockout) or recreate the pages in Blazor.

It is quite an achievement that you got the tabs to show something. I will accept this pull request.

medhatelmasry commented 4 months ago

Decided to keep this issue open because the page does nothing

ydongchoi commented 4 months ago

I found why it doesn't work. That was script tag src problem in knock out. I changed script src and solved it like below image.

Result

image

Next

I will make new issue branch and push code and then pull request.

medhatelmasry commented 4 months ago

Wonderful, Yeongdong. Thanks a lot for your help. I have a very good feeling about making significant progress in this project.

Regards, Medhat Elmasry

On Sun, Jul 7, 2024 at 4:52 PM Yeongdong Choi @.***> wrote:

I found why it doesn't work. That was script tag src problem in knock out. I changed script src and solved it like below image. Result

image.png (view on web) https://github.com/medhatelmasry/GoodBooks/assets/84194034/e0b41275-cda1-434e-83f2-ee49d9029bd1 Next

I will make new issue branch and push code and then pull request.

— Reply to this email directly, view it on GitHub https://github.com/medhatelmasry/GoodBooks/issues/11#issuecomment-2212621382, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4UQQGKWOAAJLK2W7V2I3ZLHICBAVCNFSM6AAAAABH7BZUTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGYZDCMZYGI . You are receiving this because you authored the thread.Message ID: @.***>

ydongchoi commented 4 months ago

I think we need to add some issue that is redirection to https://good-books.azurewebsites.net/#settings when clicking sidebar menu. Could this be a problem caused by using knockout and blazor together?

medhatelmasry commented 4 months ago

When the "Accounts Receivable" top menu item is clicked, it goes to

settings

All the other top menu items lead to #settings

We need to update the code so the top menu items lead nowhere

Regards, Medhat Elmasry

On Sun, Jul 7, 2024 at 8:19 PM Yeongdong Choi @.***> wrote:

I think we need to add some issue that is redirection to https://good-books.azurewebsites.net/#settings when clicking sidebar menu. Could this be a problem caused by using knockout and blazor together?

— Reply to this email directly, view it on GitHub https://github.com/medhatelmasry/GoodBooks/issues/11#issuecomment-2212910283, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4UQWUXB2MLZKEW23CJWDZLIAM7AVCNFSM6AAAAABH7BZUTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSHEYTAMRYGM . You are receiving this because you authored the thread.Message ID: @.***>

ydongchoi commented 4 months ago

I solved problem. Whenever clicking sidebar menu, it rerendered to "/" appended by href = "#settings". when i removed below code, it was solved. However, If we wanna existing mvc apps with blazors, we have to make new solution referencing below link. Same Issue1 : https://github.com/dotnet/aspnetcore/issues/43191 Same Issue2 : https://stackoverflow.com/questions/8108836/make-anchor-links-refer-to-the-current-page-when-using-base

Code

image

medhatelmasry commented 4 months ago

Thanks Yeongdong. Your solution is very good. As I said before, the bulk of this code came from the open source project so there are many minor issues that need to be fixed.

Regards, Medhat Elmasry

On Mon, Jul 8, 2024 at 12:16 PM Yeongdong Choi @.***> wrote:

Do we need href in a tag? Whenever clicking sidebar menu, It navigate to

settings. Same goes for other menus.

Actually, as you know, #settings will be appended to existing uri. however, it goes to / and appended. So it navigates to #settings. I think something was happened to navigate to / when clicking menu like below url result.

Expected Result : http://localhost:8000/Quotations/Quotations/#settings Actual Result : http://localhost:8000/#settings

When i removed href, the problem was solved. Code

image.png (view on web) https://github.com/medhatelmasry/GoodBooks/assets/84194034/610b4924-6a10-4e3b-a038-63dd893a1e1c

— Reply to this email directly, view it on GitHub https://github.com/medhatelmasry/GoodBooks/issues/11#issuecomment-2214989186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4UQUMESXSX2YC7QMJFU3ZLLQRXAVCNFSM6AAAAABH7BZUTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHE4DSMJYGY . You are receiving this because you authored the thread.Message ID: @.***>