medhatelmasry / voting-tool-cms

1 stars 2 forks source link

Maps controller on the backend is broken #75

Closed medhatelmasry closed 4 years ago

medhatelmasry commented 4 years ago

The maps controller at the backend is not working properly

Test that this request returns response:

/maps?longitude=1234&latitude=-1234

reneilpascua commented 4 years ago

communicated with Ivan, as this issue is strongly connected to issue #52 "mapping tool needs to work properly"

reneilpascua commented 4 years ago

if @Ivan1120 does not respond by 17:00, i will need to take over this issue (#75) to further my fix for issue #52

reneilpascua commented 4 years ago

note: from the old project's mapscontroller, its endpoint specifies a string location which i understood to be 2 doubles separated by comma

example: ~/api/maps/-123.1011,49.204

image

reneilpascua commented 4 years ago

everything works now but keep in mind that the requests to this endpoint (as it is right now) must come in the form of {double longitude},{double latitude}

example: api/maps/-123.1139,49.2710

next steps:

note: this took a lot of research and debugging and, in my opinion, should be higher than a level 3. please refer to pull request 93 for the resolution of this issue