media-centre / makenews

MakeNews is for journalists and newsrooms. It helps you track news from web and social media in real-time.
https://makenews.in
GNU Affero General Public License v3.0
53 stars 22 forks source link

Add pre push hook for linting and testing #145

Closed muralikrishna8 closed 4 years ago

muralikrishna8 commented 5 years ago

We can add husky and add the hooks there https://www.npmjs.com/package/husky

muralikrishna8 commented 4 years ago

For now added the pre-push hook for linting and testing.

Need to add the pre-commit hook for running the eslint --fix just for the changed files. That should:

But for that we need to make some changes to the way we have our lint configured. Either we can find a way to do it with the gulp, or we can just use the eslint command directly without having the gulp task.

Closing this issue for now, and will work on the pre-commit hook as part of a #150