media-io / yaserde

Yet Another Serializer/Deserializer
MIT License
175 stars 57 forks source link

Add skip_serializing_if support for attributes #108

Closed olvyko closed 3 years ago

olvyko commented 3 years ago

Before that change skip_serializing_if won't work for struct fields that marked as attribute. I changed ser_wrap_default_attribute func and added test for that change.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 273


Changes Missing Coverage Covered Lines Changed/Added Lines %
yaserde_derive/src/lib.rs 0 2 0.0%
yaserde_derive/src/common/field.rs 0 5 0.0%
<!-- Total: 17 24 70.83% -->
Files with Coverage Reduction New Missed Lines %
yaserde_derive/src/common/field.rs 1 0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 272: 0.3%
Covered Lines: 1141
Relevant Lines: 1905

💛 - Coveralls
enfipy commented 3 years ago

Any news on this?

enfipy commented 3 years ago

@MarcAntoine-Arnaud Thanks! Can you also publish a new version? It will help us publish android-manifest to crates.

MarcAntoine-Arnaud commented 3 years ago

Done with the 0.7.0, sorry for the delay.