search

media-kit / media-kit

A cross-platform video player & audio player for Flutter & Dart.
https://github.com/media-kit/media-kit
MIT License
1.09k stars 175 forks source link

[Enhancement] seamless loop #150

Open zhahouming opened 1 year ago

zhahouming commented 1 year ago

In the single file loop playback mode, there is a delay between the two loops, which prevents a perfect seamless connection. This is a problem with the original MPV library, and here is the related fix PR link https://github.com/mpv-player/mpv/pull/10748, FYI.

alexmercerind commented 1 year ago

Not really a necessity, even more so at the moment.

rekire commented 1 year ago

Is there currently a workaround for looping videos?

alexmercerind commented 1 year ago

@rekire

Is there currently a workaround for looping videos?

There's a dedicated solution, not a workaround.

await player.setPlaylistMode(PlaylistMode.loop);

This issue is for seamless loop, not loop.

nialljawad96 commented 1 year ago

Second this. Looping with a gap breaks the experience.

zhahouming commented 1 year ago

Second this. Looping with a gap breaks the experience.

@nialljawad96

The mpv repository needs to merge this pull request first. People with requirements can go there and leave more comments. https://github.com/mpv-player/mpv/pull/10748,

moffatman commented 11 months ago

Note for future fix

This is due to mpv_get_property within render callback to find the current video width/height, which is not allowed per mpv docs. Need to subscribe to those properties in another thread and send them to be cached in render thread

elvinasn commented 3 weeks ago

Any news on this? The gap really breaks the good experience.