Enable --vo=gpu-next Support on Darwin to Reshape Dolby Vision Content

media-kit / media-kit

A cross-platform video player & audio player for Flutter & Dart.

https://github.com/media-kit/media-kit

MIT License

893 stars 126 forks source link

Enable --vo=gpu-next Support on Darwin to Reshape Dolby Vision Content #777

Closed shivabohemian closed 4 weeks ago

shivabohemian commented 4 weeks ago

In the latest version of mpv 0.38, the issue with Vulkan instance creation on macOS has been fixed (the pr). Here, we can use --vo=gpu-next to support content reshaping for Dolby Vision (you can use test videos here). I noticed that the darwin builds of the media-kit package are using an older version of mpv and Vulkan is not enabled. So, do we need to update libmpv-darwin-build?

birros commented 4 weeks ago

See media-kit/libmpv-darwin-build#28.

Unfortunately, I don't think libmpv uses Vulkan, but only OpenGL like previous versions. It seems to me that Vulkan is only for direct rendering in a native view.

To use Vulkan in media-kit, we need to :

Wait for libmpv to replace OpenGL with Vulkan
Or use a Platform View from Flutter, but I don't think this API is yet stable for macOS, and that it would be as efficient

shivabohemian commented 4 weeks ago

All right. It looks like gpu-next is still not supported in the rendering API (https://github.com/mpv-player/mpv/issues/10810). So, as it stands, it appears that Dolby Vision tone mapping is also not properly supported on the medit-kit.