This pull request updates the error handling for HTTP headers in the web-specific implementation of our Media class. The adjustment is made to prevent unsupported HTTP header operations on web platforms more effectively.
I've refined the HTTP header checks to throw an UnsupportedError only when httpHeaders is not null and contains one or more key-value pairs. This ensures that empty maps, which are the default state in some instances, do not trigger errors, aligning with the typical usage scenarios on web platforms where HTTP headers might be intentionally left unset.
Impact:
This change will prevent the unnecessary triggering of exceptions for empty HTTP header maps, reducing confusion and aligning error handling with actual unsupported use cases.
Description:
This pull request updates the error handling for HTTP headers in the web-specific implementation of our Media class. The adjustment is made to prevent unsupported HTTP header operations on web platforms more effectively.
Context:
In the current architecture, the
DataSourceclass https://github.com/media-kit/media-kit/blob/dad52462dd56643ba27d4c581bbcff0fce8fbde1/video_player_media_kit/lib/src/media_kit_video_player.dart#L90, defaults to an empty map if no headers are provided. The prior check in our code did not handle this default case, potentially leading to unintended behavior when an empty map is incorrectly treated as a valid input.Changes:
I've refined the HTTP header checks to throw an
UnsupportedErroronly whenhttpHeadersis not null and contains one or more key-value pairs. This ensures that empty maps, which are the default state in some instances, do not trigger errors, aligning with the typical usage scenarios on web platforms where HTTP headers might be intentionally left unset.Impact:
This change will prevent the unnecessary triggering of exceptions for empty HTTP header maps, reducing confusion and aligning error handling with actual unsupported use cases.