search

media-kit / media-kit

A cross-platform video player & audio player for Flutter & Dart.
https://github.com/media-kit/media-kit
MIT License
893 stars 126 forks source link

Add macOS tests to CI #785

Closed default-anton closed 3 weeks ago

default-anton commented 3 weeks ago

Successful test run in my fork of media-kit https://github.com/default-anton/media-kit/actions/runs/8827709200/job/24235400264

default-anton commented 3 weeks ago

There is a flaky test that failed on Linux and macOS 😢 .

All tests are green in my fork https://github.com/default-anton/media-kit/actions/runs/8827709200

abdelaziz-mahdy commented 3 weeks ago

i reran the failed ci, hopefully all goes green

default-anton commented 3 weeks ago

Failed on linux again 🤔 Should we flag it as flaky for now?

abdelaziz-mahdy commented 3 weeks ago

Failed on linux again 🤔 Should we flag it as flaky for now?

I don't know how and why it's flaky so it's not my decision to make sadly,

Alex is the one to decide,

For now I reran it.

abdelaziz-mahdy commented 3 weeks ago

Looks like it went well this time.

We may need to add retries for the flaky tests to avoid this problem in the future

default-anton commented 3 weeks ago

Hey @alexmercerind, looks like all tests are passing on macOS. Can we go ahead and merge this PR? 🥺

alexmercerind commented 3 weeks ago

Thanks for your contribution.

I consider flaky tests a problem in in the implementation (& not the tests). Ideally, implementation should be fixed/changed to work in all cases, no matter where (locally, CI, etc.). If tests are failing in some cases, this clearly indicates some kind of race situation (even if it works well on our local devices mostly).

Previously, I have resolved this flaky tests by updating implementation. It may take some time.

I don't have any bandwidth to spare presently unfortunately.