media-kit / media-kit

A cross-platform video player & audio player for Flutter & Dart.

https://github.com/media-kit/media-kit

MIT License

893 stars 126 forks source link

improving seek speed #791

Closed abdelaziz-mahdy closed 2 weeks ago

abdelaziz-mahdy commented 3 weeks ago

we were using absolute which uses exact and from the docs looks like that is slow, when testing with the new code it seems faster, but i dont feel that the workaround i did to allow such logic is good,

so this needs further testing and a better/cleaner position logic

issues i found which needs to be fixed before merging:

[x] multiple seeks in the same time is not working correctly due to position not being updated

from my testing for now it should be all good and seeking is faster when called multiple times (that was a problem in general ) and seeking is 50% faster from what i feel

abdelaziz-mahdy commented 3 weeks ago

i cant figure out why the test case is failing since the seek works, but looks like its not as accurate as absolute in exchange for speed i think thats a good trade.

user1121114685 commented 3 weeks ago

Precise jump positioning is really not necessary. Users don’t click very accurately. I agree with this update.

In addition, I have a question that is not related to this update. I would like to ask about whether the automatic next episode is triggered by mpv? Or media-kit. I didn't find the relevant code for the next episode in the media-kit.

abdelaziz-mahdy commented 3 weeks ago

Precise jump positioning is really not necessary. Users don’t click very accurately. I agree with this update.

In addition, I have a question that is not related to this update. I would like to ask about whether the automatic next episode is triggered by mpv? Or media-kit. I didn't find the relevant code for the next episode in the media-kit.

its handled by mpv, and can you test this pr and see if the seek is faster or not in your case

user1121114685 commented 3 weeks ago

Precise jump positioning is really not necessary. Users don’t click very accurately. I agree with this update. In addition, I have a question that is not related to this update. I would like to ask about whether the automatic next episode is triggered by mpv? Or media-kit. I didn't find the relevant code for the next episode in the media-kit.

its handled by mpv, and can you test this pr and see if the seek is faster or not in your case

Thanks, I'd like to test it, but one of these days I'll be back in a small town where I don't have a computer to program with. I can test it after I come back, which will take 3 days. Thank you for your enthusiastic reply.

alexmercerind commented 2 weeks ago

No. This is not a solution. It's not really ideal to have 2-3 seconds mismatch, many of our users actually rely on accurate seek (which in-fact is default in most applications).

alexmercerind commented 2 weeks ago

Of course... If one wishes to experiment themselves, they are free to use the hidden setProperty API.

abdelaziz-mahdy commented 2 weeks ago

from my test the mismatch was close to 0.5 sec but if you got higher values i dont think this can work, so i agree with you

default-anton commented 2 weeks ago

I tried this yesterday. It couldn’t let me seek 15s forward on a long video file. It was jumping back to the closest keyframe.

For certain use cases that’s probably not an issue, so we can at least file an issue to make this configurable

alexmercerind commented 2 weeks ago

Of course... If one wishes to experiment themselves, they are free to use the hidden setProperty API.

FYI: There's a similar command API too: #586