search

mediachain / L-SPACE

[DEPRECATED] Books = Knowledge = Power = (Mass x Distance^2) / Time^3
MIT License
9 stars 1 forks source link

[pending upstream changes] Transaction support #30

Closed parkan closed 8 years ago

parkan commented 8 years ago

Many of the ops need to happen inside a transaction; this is currently not supported under orientdb-gremlin: orientdb-gremlin/issues/16

TODO: think about equivalent on IPFS

yusefnapora commented 8 years ago

Maybe transactions are supported after all...

This got merged in November: https://github.com/mpollmeier/orientdb-gremlin/pull/17 but the issue is still open. I'll dig into the code a bit and see if I can sort it out

parkan commented 8 years ago

This appears to be addressed in 15f1462bea96cd80948af718877202b11ef51724

I see withTransaction used in Merge, I guess we should switch to it in Ingress as well? Do we still need monadic transaction support or is this good enough?

yusefnapora commented 8 years ago

I haven't thoroughly nested transactions yet, but I think they should work.

bigs commented 8 years ago

on advantage of a monadic transaction API would be transaction flattening i.e. only a single layer

parkan commented 8 years ago

@bigs my understanding was that there is no nested transaction support at all, so we already kind of address that here: https://github.com/mediachain/L-SPACE/commit/15f1462bea96cd80948af718877202b11ef51724#diff-c146692e98427deb835eca75000291daR27

or do you mean something else?

bigs commented 8 years ago

@parkan i think the worry was that the transaction support was more or less a no-op. @yusefnapora?

yusefnapora commented 8 years ago

@bigs, transactions are only a no-op if you use OrientGraphFactory().getNoTx(). But we switched over to getTx() when we started creating vertex and edge classes with the migration stuff. So they should be enabled now

parkan commented 8 years ago

Some issues with this tracked down and addressed by the fearless yusef in https://github.com/mediachain/L-SPACE/pull/49/commits/047e41a76dd7ada956d82265ce3ba6f1c6f5a047