mediachain / L-SPACE

[DEPRECATED] Books = Knowledge = Power = (Mass x Distance^2) / Time^3
MIT License
9 stars 1 forks source link

Translator/Loader refactor #32

Closed parkan closed 8 years ago

parkan commented 8 years ago

Oook this ended up getting kind of out of scope, plz take a look (needs some style cleanup and a slight rejigger with how self-types are [not] used)

parkan commented 8 years ago

Ok, this should be good to merge now (once tests pass)

parkan commented 8 years ago

Ok and good to merge git-wise now too. Feel free to comment, I think I addressed most concerns though

parkan commented 8 years ago

Ok upon self-review things that are missing are:

Anything else?

parkan commented 8 years ago

@bigs: if you want to take some of this off my plate, I would suggest doing a throw safety pass through the parser. Specifically, calls to nextToken like here can throw on malformed json and should be wrapped like so

The other related things are: