Closed parkan closed 8 years ago
Ok, this should be good to merge now (once tests pass)
Ok and good to merge git-wise now too. Feel free to comment, I think I addressed most concerns though
Ok upon self-review things that are missing are:
Anything else?
@bigs: if you want to take some of this off my plate, I would suggest doing a throw safety pass through the parser. Specifically, calls to nextToken
like here can throw on malformed json and should be wrapped like so
The other related things are:
createParser
, there's a few spots where that should happennextToken
calls that consume nulls into the above call (I don't like remembering to call this manually)
Oook this ended up getting kind of out of scope, plz take a look (needs some style cleanup and a slight rejigger with how self-types are [not] used)