Manifest support in directory

mediachain / concat

Mediachain daemons

MIT License

42 stars 13 forks source link

Manifest support in directory #125

Closed vyzo closed 7 years ago

vyzo commented 7 years ago

Adds manifest support in mcdir; closes #71

Refactor mcdir in multiple files
impelement a manifest store in mcdir for tracking all manifests from registered nodes
implement /mediachain/dir/listmf protocol for looking up manifests by entity id
Add /dir/listmf/{entity} api in mcnode

yusefnapora commented 7 years ago

This is looking good. I guess when we have a large volume of node registrations with manifests we can do the async entity lookup, but for now it seems fine to hold the lock until it completes.

Not really related to this mcdir PR, but does the node do its own manifest verification when it fetches a remote manifest? I guess that would require the node to have its own ManifestStore and do the entity lookups, etc...

Anyway, this looks good to me :)

vyzo commented 7 years ago

No, nodes don't do their own verification -- mainly because I don't want to have a dependency on blockstack for running mcnode. So they trust the directory, and the end user client can do its own verification if need be.

Not: the lock is not held while the slow part is running, it is released temporarily while the key lookup is in progress; the rest should run fast enough to not be an issue.