node local store - Githubissues

vyzo commented 7 years ago

Implements the node Local Store with a relational db, backed by SQLite. Closes #10

Summary:

Refactor mcnode to abstract the statement db; RIP old dumb implementation.
Implement the StatementDB with a generic SQL database and provide an SQLite backend specialization
Implement compilation of MCQL queries to SQL for evaluation by the StatementDB
Implement streaming results with ndjson in the /query API
Implement deletion: Add DELETE to the MCQL grammar and expose through a /delete api

ISSUE: the gx vendored gogo-protobuf does not marshal/unmarshal oneof, which breaks statement bodies. Looking for resolution in https://github.com/ipfs/go-ipfs/issues/3214 Fixed in https://github.com/mediachain/concat/pull/21/commits/fa3cc53d969dcd807c3eeaa85c82f1cf8187cff5

yusefnapora commented 7 years ago

Okay, finally made it through the commits 😄

It's looking good to me; I like the streaming query interface, and you did a great job with the test coverage. I think we should probably merge this in before it gets any bigger :)

vyzo commented 7 years ago

Yeah, I think I am done with it :)

mediachain / concat

node local store #21