mediachain / oldchain-client

[DEPRECATED] old mediachain client experiments
MIT License
4 stars 2 forks source link

Send higher res thumbnails, enable image download by default #77

Closed yusefnapora closed 8 years ago

yusefnapora commented 8 years ago

This changes the thumbnail scaling to only scale down to 1024 pixels max, and changes the default ingestion behavior to download thumbnail images from http uris if present in the translator output.

Removes the --download-thumbnails flag, and replaces with a --skip-image-downloads flag, which will opt you out of downloading images if you have performance concerns, etc.

With this, I can run e.g.

mediachain  ingest artsy@QmbX6FdEREGv6SHDA2XGvarcpv7DefBwFuaCzXY5tkbSLp ~/artsy.json

and it will give me artsy data including the ipfs link to the thumbnail:

"data": {
      "category": "Print",
      "medium": "Etching",
      "artist": "Giovanni Domenico Tiepolo",
      "created_at": "2013-04-03T03:30:26+00:00",
      "title": "The Rest on the Flight, with Holy Family under a Tree",
      "collecting_institution": "National Gallery of Art, Washington D.C.",
      "image_url": "https://d32dm0rphc51dk.cloudfront.net/b2EpUlEJ4LN0o5gzVj1EVw/normalized.jpg",
      "_id": "artsy_515ba252cd4b8ed0b9000ce2",
      "thumbnail": {
        "@link": "QmdxNJocZBQs9xiUMJPY1rQ6ojGR6YWrcuMBgT5SAjSoo7"
      }
    }
  },

The indexer will see the thumbnail_base64 of the larger image.

The getty translator needs to be updated to take advantage of this, since ATM we're using the small "thumb" image, which is only a couple hundred pixels. We can change that to use the (watermarked) "comp" image instead, and the indexer can scale it down.

parkan commented 8 years ago

Let's try it out