Always include suffix if private suffix enabled and private suffix exists (#300)
Add a 4th field is_private: bool, to the ExtractResultnamedtuple, indicating whether the extraction came from the PSL's
private domains or not.
This could cause issues when iterating over the tuple and assuming
only 3 fields.
Previously, the docs promoted iteration to rejoin parts of the tuple.
This is better achieved by individual access of fields of interest
(e.g. ExtractResult.subdomain) or convenience properties (e.g.
ExtractResult.{fqdn,registered_domain}).
Always include suffix if private suffix enabled and private suffix exists (#300)
Add a 4th field is_private: bool, to the ExtractResultnamedtuple, indicating whether the extraction came from the PSL's
private domains or not.
This could cause issues when iterating over the tuple and assuming
only 3 fields.
Previously, the docs promoted iteration to rejoin parts of the tuple.
This is better achieved by individual access of fields of interest
(e.g. ExtractResult.subdomain) or convenience properties (e.g.
ExtractResult.{fqdn,registered_domain}).
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Updates the requirements on tldextract to permit the latest version.
Release notes
Sourced from tldextract's releases.
Changelog
Sourced from tldextract's changelog.
... (truncated)
Commits
c92ad1f
3.6.0ef8266e
Prepare CHANGELOGa5ed870
Fix lingering docs TypeError789f6ef
Always include suffix if private suffix enabled and private suffix exists (#300)314b982
3.5.099d7b8b
DRY reference to READMEc458e14
migrate setup.py to pyproject.toml (#299)68477c5
Clarify magic numbers07a406e
Clarify chain3a30cb5
Add support for IPv6 addresses (#298)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show