Closed rahulbot closed 1 year ago
Question:
Could defaulting of the publication_date be done just as well in the story-indexer "importer"?
Regarding #61: I agree, there are two distinct semantics:
I dove in and addressed this by adding in overrides
and defaults
as two separate new params to extract
. See #64
Some of our sources of data include a machine-readable publication date, for instance from an RSS feed. We've found this date to be highly unreliable in the past, but it would be a useful fallback to use in case a date can't otherwise be found in the text.
We should support passing in a default publication date in the
extract
method, to be used if a date can't be found. Could be solved with same solution as #61 proposes, even though a wrinkle is that forlanguage
the passing in value would be an override and in this case withpublication_date
if would be a fallback... potentially confusing inconsistency.Related: It would be a useful side-project to have some data to re-assess the match between publication dates supplied in RSS feeds, publication date guessed by this library, and publication date parsed out by a person. That would help us re-assess and support this policy of trusting guessed date over RSS date.