search

mediacloud / news-search-api

Internal API server that offers search access to the Media Cloud Online News Archive (in Elasticsearch).
https://mediacloud.org
GNU Affero General Public License v3.0
1 stars 3 forks source link

[DRAFT] Linting etc #53

Closed pgulley closed 7 months ago

pgulley commented 7 months ago

Added linting and typing hooks. This is without mypy typing corrections- just bypassing those while I get these installed. I see 64 mypy errors- I'll clean these up soon

pgulley commented 7 months ago

With the caveat that I've been unable to test this, it's ready for review

pgulley commented 7 months ago

What's up with requirements-dev.txt including all the same things that are in requirements.txt? That seems weird.

The way the pre-commit-wrapper sets up the dev environment wasn't working without that tweak- I that could be fixed if we used a pyproject.toml config instead of the approach we have now

pgulley commented 7 months ago

After some tweaks, test pass! https://github.com/pgulley/news-search-api/actions/runs/7414877287

Wasn't able to link these tests to the PR successfully, but they run locally and in gh