search

mediacloud / news-search-api

Internal API server that offers search access to the Media Cloud Online News Archive (in Elasticsearch).
https://mediacloud.org
GNU Affero General Public License v3.0
1 stars 3 forks source link

Ft/deployment setup #66

Closed thepsalmist closed 2 months ago

thepsalmist commented 4 months ago

This PR creates a workflow to deploy the news-search-api separately from the story-indexer. Define workflow to deploy to staging & production

thepsalmist commented 4 months ago

PS: We setting the SENTRY_DSN in the private story_indexer repo?

philbudne commented 4 months ago

Sure on the ESHOSTS, but the ui still references the api using the container name APIURL: http://api:8000/v1, so I guess retaining a custom defined network rather than using the default docker bridge network provides for better isolation

Containers in the same stack can always reach each other. As long as the servers where development, staging and production stacks are run are not in the same swarm cluster, the network name can be static, but requiring an external network doesn't seem necessary to me.

thepsalmist commented 2 months ago

@kilemensi you can have a final review