search

mediacloud / story-indexer

The core pipeline used to ingest online news stories in the Media Cloud archive.
https://mediacloud.org
Apache License 2.0
2 stars 5 forks source link

Elasticsearch INDEX_NAMES is depreciated on NewsSearchApi currently, might want to repreciate after the database update #224

Closed pgulley closed 9 months ago

pgulley commented 10 months ago

https://github.com/mediacloud/story-indexer/blob/d6bed1b5e971614ed4f31253dc372914f645eafa/docker/docker-compose.yml.j2#L142

The News_Search_Api now finds exposed indices on its own, rather than piping them in like so. Furthermore, after the database update, we'll have a new naming convention that might make the whole configuration and discovery thing- totally unnecessary, since only the one mc_search collection name will be exposed.

I don't think anything will break when we make the switch, since nothing is setting the ELASTICSEARCH_INDEX_NAME_PREFIX on the news_search_api anyway, but after the switch we might want INDEXES=mc_search and change the news_search_api to respect that setting, or just remove the INDEXES setting altogether and let every index be exposed.

As it stands in this moments it's just jetsam.

thepsalmist commented 9 months ago

This here already solves the above

rahulbot commented 9 months ago

Closing as already completed based on note above.