mediacloud / story-indexer

The core pipeline used to ingest online news stories in the Media Cloud archive.
https://mediacloud.org
Apache License 2.0
2 stars 5 forks source link

Deployment warnings from docker #339

Open philbudne opened 1 month ago

philbudne commented 1 month ago

I've been seeing these warnings on ifill when deploying the story-indexer stack:

 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match

WARN[0000] /nfs/ang/users/pbudne/story-indexer/docker/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 

Since --detach=false was not specified, tasks will be created in the background.
In a future release, --detach=false will become the default.
kilemensi commented 1 month ago

Yeah, docker now supports build ---checks for build configuration analysis (even in GitHub Actions)

version in docker-compose.yml was dropped a few years ago, when the two versions were merged into one specification.