rahulbot
commented
12 months ago Merging because the WM integration tests that are failing are ones we aren't surprised by:
waybacknews.tests.test_waybacknews.TestMediaCloudCollection.test_domain_and_url_search: we know wildcard URL searching failswaybacknews.tests.test_waybacknews.TestMediaCloudCollection.test_reserved_characters: (same reason)waybacknews.tests.test_waybacknews.TestMediaCloudCollection.test_top_terms: something wrong on IA server
This set of wacky CI configurations adds a new test. It checkouts out
news-search-api@main, uses that to insert test data into an ES instance via Docker, and then runs a smaller set of unit tests to verify results of using this API client work. Why? To help us make sure that this api-client can talk to the api-server as we expect it to in a controlled environment (ie. test ES data). This helps build confidence that we don't muck up a low-level integration, at the expense of adding more tests to maintain... kind of a classic tradeoff. See https://github.com/mediacloud/news-search-api/issues/27#issuecomment-1846462814 for more thoughts that led me here.Maybe this won't be useful over time, but it seems useful right now as we are still working to establish production-level build and deployment processes across all these repos. I am going to merge so that I can continue the integration work up the call chain.