mediacloud / web-search

Code that drives the public web-based tools for the Media Cloud Online News Archive and Directory.
https://search.mediacloud.org
Apache License 2.0
9 stars 15 forks source link

Enable tracing #655

Closed pgulley closed 3 months ago

pgulley commented 4 months ago

Just a draft- incase we want to think about adding any subtraces to web-search

pgulley commented 3 months ago

I've concluded that some additional custom instrumentation would be needed if we wanted a span that covered actions taken in response to the user clicking "search" - which is, I think, the key user experience metric at the end of the day- but I also think we can get away with optimizing based on each individual API call for now.

Relatedly, I'm also a little disappointed that there doesn't seem to be a way to pipe in settings to the frontend sentry configuration except for by hard coding them in the react root.jsx- Ideally we could set these at the deployment level, especially the "environment" variable.

pgulley commented 3 months ago

subsumed in #679