mediacloud / web-tools

The shared repository for Media Cloud web apps (Explorer, Source Manager, Topic Mapper)
https://tools.mediacloud.org
Apache License 2.0
64 stars 30 forks source link

Media List download in Topic Mapper is not reflecting story search filter #1401

Closed ebndulue closed 5 years ago

ebndulue commented 5 years ago

I applied the filter of a subtopic then also used a story search filter. The story list appears to be updating correctly, but the media list is not. (It says that there are thousands of stories published by the top source, when there are less than 50 in the results once both filters are applied).

rahulbot commented 5 years ago

Can you give us the topic, subtopic, and story search you noticed this with? I'm having trouble reproducing it.

ebndulue commented 5 years ago

Topic = https://topics.mediacloud.org/#/topics/2421/summary Subtopic is the only existing one - Conversations:Conversations The story search query is ("Red Nose Day" OR "RedNoseDay")

Thanks!

rahulbot commented 5 years ago

Thanks, that helped me track this down. I think what is happening here is that the media lists are respecting both filters, but the aggregated data about the media source is ignoring the search query filter. This means the media CSV downloaded's stories, media inlinks, outlinks, and Facebook Shares columns are all wrong if you have a story-search filter in place. The list of media sources is right though (it is respecting both the search query filter and the subtopic filter.

Details

With both filters in place:

With just the subtopic in place:

With no filters in place:

rahulbot commented 5 years ago

Proposal: add text like this above the media table if there is a story search filter in place:

"Warning - the results below are easy to mis-read. The media story counts, inlink counts, outline counts, and shares all ignore your story search. For instance, the stories count for a media source in the table below is the number of stories from this media source in this timespan and subtopic, NOT the number of stories in this timespan and subtopic matching your story search filter. If you want to recompute these numbers turn your story search into a new subtopic."

@AnissaPierre can you take a pass at producing better text for this?

AnissaPierre commented 5 years ago

Hows this?

 Please be advised: the media story counts, inlink counts, outline counts, and shares do not reflect your filter! These      numbers reflect all of the stories from the source within your timeframe and topic/subtopic. If you want to see             these numbers for your filter, turn your filter into a new subtopic.

On Dec 6, 2018, at 3:53 PM, rahulbot notifications@github.com wrote:

Warning - the results below are easy to mis-read. The media story counts, inlink counts, outline counts, and shares all ignore your story search. For instance, the stories count for a media source in the table below is the number of stories from this media source in this timespan and subtopic, NOT the number of stories in this timespan and subtopic matching your story search filter. If you want to recompute these numbers turn your story search into a new subtopic

rahulbot commented 5 years ago

Thx - will integrate!

rahulbot commented 5 years ago

This warning shows up above any media table in topic mapper if you have a story search filter in place: philanthropy_for_gates___topic_mapper___media_cloud