search

mediacloud / web-tools

The shared repository for Media Cloud web apps (Explorer, Source Manager, Topic Mapper)
https://tools.mediacloud.org
Apache License 2.0
64 stars 30 forks source link

advanced source search: separate display of selected and suggested tags #1563

Closed rahulbot closed 5 years ago

rahulbot commented 5 years ago

Right now all the tags you select show up under "Frequently Used": Search___Explorer___Media_Cloud

This isn't the right behavior. Any unselected suggestions should show up under "Frequently Used". All selected items (whether suggested or not) should show up above "Frequently Used". As per the mockup: advanced_search

I think this means two FieldArrays, one above and one below. Perhaps just some filter calls on the initalValues or the previouslySelected before they get passed to the FieldArray? We'd only care about storing the first FieldArray - the one with all the selected items. The other is just unselected checkboxes for suggestions the user didn't pick.

cindyloo commented 5 years ago

ok, so if a user checks USA, then the box in Frequently Used is checked and a duplicate checkbox appears above in the 'selected' section? or does it move up?

rahulbot commented 5 years ago

This is a good question. From a user-point of view it makes sense for the checkbox to stay where it is, because that's what people expect check-boxes to do. From an information-architecture point of view I'd say it should move up to the list of "selected items", above the "Frequently Used" area. As I think about it more now that you've asked, I think the first (user-centric) approach is the right one... people won't expect it to move so it should stay where it is.