mediacms-io / mediacms

MediaCMS is a modern, fully featured open source video and media CMS, written in Python/Django and React, featuring a REST API.
https://mediacms.io
GNU Affero General Public License v3.0
2.88k stars 534 forks source link

feat: fullscreen images slideshow #1120

Open aleensd opened 1 week ago

aleensd commented 1 week ago

Description

Steps

Pre-deploy

Post-deploy

mgogoulos commented 1 week ago

Great to see this! Is it ready for testing in demo? Make sure you push the static files as well!!!

aleensd commented 1 week ago

@mgogoulos i still need to clean up the code a bit test it more and add keyboard keys functionalities

mgogoulos commented 5 days ago

This looks great so far!

I've made these two changes and pushed them in main, can you sync in order to get them?

  1. the slideshow_items now returns the first item as the image itself. Thus when you click on the image, you get that image as the first fullscreen item. Before this, you would get another image as first, and that would be strange!
  2. I've made the number of slideshow items as configurable, checkout files/models.py on slideshow_items = getattr(settings, "SLIDESHOW_ITEMS", 30)

It expects a setting SLIDESHOW_ITEMS and will read that number, otherwise it sets a default of 30. If you want, give it a test, eg upload a larger number of images, and increase this number to see how they look

Other than that, I have the following suggestions: