Users cannot comment when upload is specified to "advanced" or "email_verified"

mediacms-io / mediacms

MediaCMS is a modern, fully featured open source video and media CMS, written in Python/Django and React, featuring a REST API.

https://mediacms.io

GNU Affero General Public License v3.0

2.53k stars 459 forks source link

Users cannot comment when upload is specified to "advanced" or "email_verified" #216

Open mstdn opened 3 years ago

mstdn commented 3 years ago

Meow there!

First of all I want to say keep up the great work on this amazing CMS!

I found a little bug that prohibits users from commenting/replying on uploaded media when the upload access is set to "AdvancedUsers" aka admins or "verified_email" so when they have not verified email. When posting a reply you'll get an error.

To Reproduce Steps to reproduce the issue:

Set upload to email_verified or advancedUser
Create a new "plain" user and comment on media
Get an error

Expected behavior In any case I would expect an user to comment on media or get the notice they need to confirm email first (when set in settings ofc).

Also an option for "anonymous" comments like with the options for

ALLOW_ANONYMOUS_ACTIONS = ["report", "like", "dislike", "watch", "comment"] <====== example "comment" or "reply"

Would be great!

Environment (please complete the following information):

OS: Ubuntu 18.04
Installation method:single server install

mgogoulos commented 3 years ago

Hey, thanks for the good words! Nice description too. I can confirm that option CAN_ADD_MEDIA when set to

email_verified, allows users with email verified to upload media + comment
advancedUser, allows users to upload media + comment only if they are labeled as advancedUser by a MediaCMS manager or admin

So the commenting ability could be decoupled - and be an option by itself (default True). I'll try to get some time to open a PR for this

antoniomiotto commented 1 year ago

any update?

mgogoulos commented 1 year ago

any update?

Not as far as myself is related, did not have time to work on this

KyleMaas commented 1 month ago

I just ran into this as well.

suempu commented 4 days ago

I have the same issue. hope there will be a new version soon

KyleMaas commented 4 days ago

My pull request #1023 fixes this.

suempu commented 3 days ago

Thank you, how can I patch this, in last stable release?

KyleMaas commented 3 days ago

@suempu Apply these changes to the code from the main branch and restart MediaCMS:

https://github.com/mediacms-io/mediacms/pull/1023/files

Don't know how to do that for a Docker install, but it's quite easy to do with a server install.

suempu commented 3 days ago

@suempu Apply these changes to the code from the main branch and restart MediaCMS:

https://github.com/mediacms-io/mediacms/pull/1023/files

Don't know how to do that for a Docker install, but it's quite easy to do with a server install.

I can do that, thanks a lot for your work.