search

mediacms-io / mediacms

MediaCMS is a modern, fully featured open source video and media CMS, written in Python/Django and React, featuring a REST API.
https://mediacms.io
GNU Affero General Public License v3.0
2.67k stars 495 forks source link

Bug: comment for image media type #683

Closed Micrufun closed 1 year ago

Micrufun commented 1 year ago

Describe the issue Comments cannot be submitted for media type of image.

To Reproduce Steps to reproduce the issue:

  1. Upload an image.
  2. Try to submit a comment for it.
  3. This notification is displayed: Comment submission failed

Expected behavior Comment should be submitted with a success notification.

Screenshots

Screen Shot 2022-12-27 at 15 31 36

Environment (please complete the following information):

Additional context: backend is fine

Strangely, the HTTP API response indicates that the comment submission was actually fine:

Screen Shot 2022-12-27 at 15 33 05

Also, taking a look at the database table, indicates that the comment is actually submitted by the backend just fine:

Screen Shot 2022-12-27 at 15 35 24

mgogoulos commented 1 year ago

Fixed via https://github.com/mediacms-io/mediacms/pull/802

There was a strange behavior that was introduced "recently", as discussed on the PR above. A new feature was preventing comments from appearing on non video files, despite the fact that they would be added on the system.

And I wish I had seen this one earlier :(