Will you accept a PR to lower the required PHP version to ^7.1?

mediact / dependency-guard

Static production dependency analysis.

MIT License

83 stars 5 forks source link

Will you accept a PR to lower the required PHP version to ^7.1? #1

Closed willemstuursma closed 6 years ago

willemstuursma commented 6 years ago

Hi, Willem from Mollie Payments here.

We saw this a few days ago on /r/php and would like to apply it to our applications. We've still got some on PHP 7.1, so hence my question: will you accept a PR to lower the required PHP version to ^7.1?

janmartenjongerius commented 6 years ago

Absolutely. I've looked into it and we definitely want to broaden to at least 7.1, since iterable was only used a couple of times as a means to speed up development, but never a goal. I do think this will cause the API to break, so we will release a version 2.0.0 after your pull request is approved.

We very much welcome your input and support!

janmartenjongerius commented 6 years ago

When you open a pull request, please assign the following reviewers:

Ashoka de Wit @sjokki
Jan-Marten de Boer @johmanx10

willemstuursma commented 6 years ago

iterable works in PHP 7.1 too, so a minor version bump is probably OK.

willemstuursma commented 6 years ago

Created #3.