search

mediacurrent / theme_generator_8

Yeoman generator for Drupal Themes - lets you quickly set up a Drupal 8 theme with sensible defaults and best practices.
MIT License
100 stars 24 forks source link

Feature/pattern scaffolding scss #115

Closed Tregonia closed 3 years ago

Tregonia commented 3 years ago

https://github.com/mediacurrent/theme_generator_8/issues/114

Tregonia commented 3 years ago

I do not understand what you are referring to with the linting. There is 1 scss file at the location that the gulp tasks. This can be expended on, but there is only 1. The contents of this css file are for style deviations we add to our styleguides. For example, the reason our icon component looks the way it does, is because the styles in this file.

Although there might be some useful things in this PR, I don't feel we need to maintain code that is part of Pattern Lab. Pattern Lab is constantly changing and don't think linting its code or doing other code updates is the best use of our time. Let's discuss with the team to determine what makes sense to keep from this PR.

rlahoda commented 3 years ago

Also, I changed the base for the PR to develop instead of main. To better track what's getting added to NPM, it makes sense to only merge into main when the code is getting release on NPM as well.