search

mediacurrent / theme_generator_8

Yeoman generator for Drupal Themes - lets you quickly set up a Drupal 8 theme with sensible defaults and best practices.
MIT License
100 stars 25 forks source link

Update README.md to suggest installing node v14 #126

Closed damienmckenna closed 2 years ago

damienmckenna commented 2 years ago

Instead of hardcoding the instructions to use a specific point release of node, this tells it to use the v14 branch.

mariohernandez commented 2 years ago

Thanks for the updates, @damienmckenna but our test have shown that the specific version we're using is the one that works the best. We've tested with other 14.x version and have experienced issues.

damienmckenna commented 2 years ago

Weird, I haven't hit any problems with 14.8 yet, though there are only the few example components to test with so far.

Have you tried looking into the problems to see if they can be fixed? You won't want to stick with v14.6.1 forever.

mariohernandez commented 2 years ago

I will do some testing to see if we can move forward with your updates. Have you ran the npm run watch task and tried updating SCSS, JSON, and Twig files? We were experiencing issues with the watch task crashing.

mariohernandez commented 2 years ago

I tested the generator using this new approach and it seems to be working normally. Will merge this PR. I also tried the same thing with NPM and using npm install -g npm@6 also seems to install the latest version for the 6 branch. Could you make the updates tot he readme to reflect this change, @damienmckenna ? Thanks for the contributions.