search

mediacurrent / theme_generator_8

Yeoman generator for Drupal Themes - lets you quickly set up a Drupal 8 theme with sensible defaults and best practices.
MIT License
100 stars 24 forks source link

Removed YOLO #21

Closed fabean closed 5 years ago

fabean commented 6 years ago

It seemed wrong to put that there right after explaining that you could run this at much as possible.

zhawkins commented 6 years ago

Were you thinking something else might be more appropriate? 🤔

zhawkins commented 6 years ago

@fabean hey, man did you mean to fork this repo and pull request your updates against your own repo? Your updates look cool but I don't think we'll be changing the project name to "Code Koalas D8 theme Generator"

fabean commented 6 years ago

@zhawkins I meant to merge those back into my own version. The name change started when I wanted to run both generators side by side. If you're up for some extra features my plan was to add:

Just today I hacked together the libraries part, it currently works if your theme's directory name matches your theme name, which to me should always be the case but when adding a component you've lost the context of the original theme you generated. I made it so the library automatically adds both css & js which isn't how you're handling the creation of components at the moment, so that should be broken out to when you add the js itself but then I need to parse the yml file itself instead of just throwing it on the end.

fabean commented 6 years ago

Reverted the name change things I did and created the pull for the new features: https://github.com/mediacurrent/theme_generator_8/pull/23

zhawkins commented 5 years ago

We've updated the repo quite a bit to bring Yeoman and friends up to date. I'm going to close this PR now. Please feel free to open another one.