search

mediacurrent / theme_generator_8

Yeoman generator for Drupal Themes - lets you quickly set up a Drupal 8 theme with sensible defaults and best practices.
MIT License
100 stars 25 forks source link

Watch command does not trigger on changes to SVGs #53

Closed Tregonia closed 4 years ago

Tregonia commented 4 years ago

Updating the markup of an .svg file does not trigger processing of the image tools.

To reproduce

  1. Start the watch process with $ npm run watch and keep an eye on it
  2. Edit any SVG that was output from the icon component
  3. Change fill, stroke, class, or any attribute

When the change to the files are saved, the watch process does not recognize the change, and does not update anything in the styleguide. As such, updates to icons requires a one-to-one build command for each icon update to review changes.

Tregonia commented 4 years ago

Updated the watch command to watch images and SVGs for triggers in the build. https://github.com/mediacurrent/theme_generator_8/pull/56

zhawkins commented 4 years ago

Thanks Tim! Merged.