search

mediacurrent / theme_generator_8

Yeoman generator for Drupal Themes - lets you quickly set up a Drupal 8 theme with sensible defaults and best practices.
MIT License
100 stars 25 forks source link

Wrong closing tag in hero.twig #66

Closed JEManndy closed 3 years ago

JEManndy commented 4 years ago

After installing (npm create yo mc-d8-theme) : In directory src/patterns/components/hero : hero.twig begins (after attach_library) with a <div> which is closed with </section> The first <div was presumably intended to be <section.

mariohernandez commented 3 years ago

Thank you for submitting this issue, @JEManndy. We have created a PR to make this correction.

Tregonia commented 3 years ago

This is integrated in https://github.com/mediacurrent/theme_generator_8/commit/c0c10d46a25e1e888cad50e763da0ece21dbbd55