search

mediacurrent / theme_generator_8

Yeoman generator for Drupal Themes - lets you quickly set up a Drupal 8 theme with sensible defaults and best practices.
MIT License
100 stars 24 forks source link

Icons namespace is not correct during integration #7

Closed Tregonia closed 7 years ago

Tregonia commented 7 years ago

During integration into Drupal, it was learned that the namespace for the icons macro is not correct with the namespace of the theme.

It is worth noting that the current setting works fine for the KSS styleguide. It is when things integrate into Drupal that this: {% include 'assets/' ~ name ~ '.svg.twig' with { must become {% include '@theme_namespace/icons/assets/' ~ name ~ '.svg.twig' with {

erichuffman-mc commented 7 years ago

I'm not sure if it's possible, but it would be helpful to add the namespace to the @include in the icons.twig file when the theme is generated with sample components. (this file: https://github.com/mediacurrent/theme_generator_8/blob/master/generators/app/templates/_src/_sample-components/_icons/icons.twig#L17)

zhawkins commented 7 years ago

Fixed via #13 Thanks yall!