search

mediaelement / mediaelement-plugins

Plugins for the main mediaelement project
405 stars 137 forks source link

Update chromecast.html #170

Open mircobabini opened 4 years ago

mircobabini commented 4 years ago

Doesn't work otherwise, the onload wrapper directive is needed.

mircobabini commented 4 years ago

Yeah, fuck my editor. Just wanted to add the wrapping line:

window.onload = function() {

karawitan commented 4 years ago

I tried to modify you PR, but hit a "refusing to merge unrelated histories" from git.. So it's on your side to rework the PR

mircobabini commented 4 years ago

It seems I don't have so much skills here, can't revert it :/ I think it's easier if you just refuse my pull request and made the edit by yourself :)

karawitan commented 4 years ago

oki let's do that

karawitan commented 4 years ago

Ha ! I found the best way I think. Please try this to build a new PR: go to https://github.com/mediaelement/mediaelement-plugins/blob/master/demo/chromecast.html Click on "Edit this file" Modify as needed Follow the instructions to create the new PR :) This way credits will go to you like they should :)

throne1986 commented 4 years ago

Hi guys, can you please check this https://github.com/mediaelement/mediaelement-plugins/issues/172 , thanks, am sorry for the disturbance

mircobabini commented 4 years ago

@berryamin here you go #173