search

mediaelement / mediaelement-plugins

Plugins for the main mediaelement project
406 stars 138 forks source link

WordPress Plugin CSS not loading for HTTPS #44

Closed arkytn closed 7 years ago

arkytn commented 7 years ago

In the WordPress plugin WP_PLUGIN_URL is used to load the CSS etc. Because it is a const it can not follow a change from http to https. The browser rejects it as cross-protocol.

Fix is easy. Replace all occurances of "WP_PLUGIN_URL" with the function "plugins_url()'

https://wordpress.org/ideas/topic/wp_plugin_url-doesnt-take-ssl-into-account

rafa8626 commented 7 years ago

I'm sorry how does this issue has a relation with this repo?

arkytn commented 7 years ago

The WP plugin

MediaElement.js - HTML5 Audio and Video https://wordpress.org/plugins/media-element-html5-video-and-audio-player/

referenced this url as the home page.

http://mediaelementjs.com/

At the bottom of the page you are referenced as the maintainer.

Sorry if it's the wrong spot. Wherre should I post it.

On Fri, May 12, 2017 at 7:22 AM, Rafael Miranda notifications@github.com wrote:

I'm sorry how does this issue has a relation with this repo?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mediaelement/mediaelement-plugins/issues/44#issuecomment-301051780, or mute the thread https://github.com/notifications/unsubscribe-auth/ACAfyQh2nTXpOqfYRP1MJeldcd3cyzlmks5r5EERgaJpZM4NZKSA .

-- Arnold Bailey | WebWrights | support@webwrights.com

rafa8626 commented 7 years ago

Oh I see. Unfortunately that plugin is completely out of date. The part I maintain is part of WP core. This plugin should be removed and I'm not familiarized with it

rafa8626 commented 7 years ago

Also, consider that the version that might be used for that plugin is way outdated, and that might cause you more issues, so I'd recommend you to upgrade your WP to get a more recent version

Please star us at https://github.com/mediaelement/mediaelement and https://github.com/mediaelement/mediaelement-plugins to continue improving the package and giving it more popularity; also tell your friends/coworkers/etc. to support the project, if you don't mind.It would be greatly appreciated it