search

mediaelement / mediaelement-plugins

Plugins for the main mediaelement project
406 stars 138 forks source link

Add top-bar plugin, fix quality, speed, context-menu plugins #63

Closed lebanggit closed 7 years ago

lebanggit commented 7 years ago

Demo: http://demo.lebang.vn/embed.html

@rafa8626 : On quality plugin. When user click change the quality. The player will waiting for change src and buffering. In order loading icon show.

We need to smooth more than. I want to immediately display the loading icon after user clicked quality.

Other case: When one quality error (404 for exam), after user clicked and player alert error then controll bar locked. User can not choose other quality.

rafa8626 commented 7 years ago

Please don't perform any changes on dist folder; otherwise, it's difficult to review any changes. All changes must be done in src folder

rafa8626 commented 7 years ago

And as another comment: we try to maintain a standard on the icons and look-and-feel of the buttons on the control bar; the Quality really breaks that look-and-feel. Just try to use a white box like the one on the CC button, and a font weight less prominent. I'm OK with the HD icon.