Closed philipkozeny closed 1 year ago
This looks really good. I'm going to wait for the CI to pass before approving.
Thanks!
We are now supporting 3 versions of nominatim where before we did 2. Is this intentional?
Not that it's a huge burden but I was wondering.
We are now supporting 3 versions of nominatim where before we did 2. Is this intentional?
Not that it's a huge burden but I was wondering.
Yeah this time it was intentional since the difference between the versions is marginal and the release cycle of nominatim is way shorter now. Although thinking about it, the base image (Ubuntu 20.x vs 22.x) has changed. So If you also don't have a good argument, I would remove the support from 4.0 :)
Yes, please remove support for 4.0.
Ok, and do you still want to build the image?
Ok, and do you still want to build the image?
no, just way too tired and overlooking things :joy: thanks for the catch
You have a [ci skip] in the squashed merge commit so the master ci doesn't run.
i know, thanks - i have seen it after the merge. just looking if i can manually trigger it or if i really need to create another commit.