fix: set executable permission for shell scripts in dockerfile

mediagis / nominatim-docker

100% working container for Nominatim

Creative Commons Zero v1.0 Universal

1.08k stars 442 forks source link

fix: set executable permission for shell scripts in dockerfile #572

Open kno20205 opened 1 month ago

kno20205 commented 1 month ago

had this error:

docker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process

i added a run command to set the. executable permission on all .sh files within the app directory

what-the-diff[bot] commented 1 month ago

PR Summary

Improved Security for Shell Scripts The change greatly enhances the security of the application by managing the permissions of all shell scripts in the /app directory. As a result, it's now harder for unauthorized scripts to run, thereby reducing potential vulnerabilities.

leonardehrenfried commented 1 month ago

Once more, these AI-generated summaries are just really great!

Thanks for this PR though, @kno20205. However, shouldn't the permissions already be present because they are there in source files?

kno20205 commented 1 month ago

I also thought so, but when I built the image locally and tried to run the container, I got a permission error. I have to mention that i use WSL and It might be just a workaround for a problem caused by Windows and WSL. It’s up to you whether to merge it, but if it could fix a potential error, why not add it? It’s better to include it than to miss it.