medialab / gazouilloire

Twitter stream + search API grabber
GNU General Public License v3.0
104 stars 17 forks source link

Uniformize setup.py & requirements.txt #74

Open boogheta opened 3 years ago

boogheta commented 3 years ago

Instead of maintaining two distinct list of dependencies, it would be best if either we got rid of requirements.txt, or if setup.py would rely on its content

Yomguithereal commented 3 years ago

Unfortunately without using something like poetry this is not as easy as it seems, especially if you need to have a difference between regular and dev dependencies and need strict deps when developing but allowing more relaxed one on the setup.py file... python's gonna python I guess

boogheta commented 3 years ago

Couldn't we have only dev dependencies in a separate requirements file for instance?

Yomguithereal commented 3 years ago

Then you need to have some kind of custom install script not to force your user to run pip install on two requirements file when developing? My point is le jeu n'en vaut peut-être pas la chandelle vs. maintenir requirements.txt + setup.py de manière parallèle :)

boogheta commented 3 years ago

I'm split :p Otherwise I have a "fantastic" idea! Let's add a github action that checks the consistency on each commit and fixes it whenever we forget! OK I'm leaving...