Improve notifications - Githubissues

medialab / hyphe-browser

Browser version of Hyphe (WIP)

GNU Affero General Public License v3.0

29 stars 4 forks source link

Closed boogheta closed 3 years ago

boogheta commented 3 years ago

[x] better distinguish warnings from errors and infos
[x] make download alert a warning notification
[x] make info/error notifications after completion batch actions / modal (MERGE ACTIONS MODAL, REDIRECTION MODAL, ~~BATCH ACTIONS~~)
[x] ~~handle API calls errors as notifications ?~~

boogheta commented 3 years ago

@robindemourat We have three different types of notifications displaying in the topbar: info / warning / error, but currently we only use two colors : blue for info and red for warning and errors, what color choice would you make instead for warnings? https://github.com/medialab/hyphe-browser/blob/121ef8d490afba7e6427d9daa5c40d77e9a9f332/app/components/Notification/notification.styl#L19-L21

robindemourat commented 3 years ago

In order to follow the convention what would you think about a yellow (possibly the same as the one for the undecided list) ?

boogheta commented 3 years ago

sounds good to me, will try it (maybe in january though ;) )