search

medialab / hyphe-browser

Browser version of Hyphe (WIP)
GNU Affero General Public License v3.0
29 stars 4 forks source link

Default tab broken on Windows #206

Closed boogheta closed 3 years ago

boogheta commented 3 years ago

Instead of displaying the indications on how to build your corpus and select your search engine, it displays a blank tab with just file:///C:/Work%20Files/Applis/HyBro/HypheBrowser-win32-x64/resources/app.asar/app/assets/tab.html while app.asar is an archive file and not a directory.

It probably comes from the way the template is called in app/constants.js that should be written in a more windows-compatible way: export const PAGE_HYPHE_HOME = 'file://' + app.getAppPath() + '/app/assets/tab.html'

It might also come from the way the app is packaged for windows and might be fixed by just upgrading our build process (cf #205)

boogheta commented 3 years ago

Trying to build without asar (archiving) activated results in the same error with the path file:///C:/Work%20Files/Applis/HyBro/HypheBrowser-win32-x64/resources/app/app/assets/tab.html which does actually exist this time, so the problem seems more due to the way of accessing this path

boogheta commented 3 years ago

confirmation the problem comes from path things: on my Linux, I encounter the same issue when running HyBro from within a folder with accents such as "Téléchargements"