Web entity edit: check all pages as start pages

medialab / hyphe

Websites crawler with built-in exploration and control web interface

http://hyphe.medialab.sciences-po.fr/demo/

GNU Affero General Public License v3.0

329 stars 59 forks source link

Web entity edit: check all pages as start pages #352

Closed jacomyma closed 4 years ago

jacomyma commented 5 years ago

Subject to discussion.

It's about the "edit web entity" page, where we see the list of pages. We now have a switch to make a page a start page.

A user suggested that we have a global switch to add all / remove all pages from the start pages list.

Pros:

Useful in certain use scenarios.
The feature is pretty common and makes sense in terms of consistency.

Cons:

We want to prevent a problematic scenario where users check all to "gain" an additional depth instead artificially
Removing all start pages does not make much sense

boogheta commented 5 years ago

Side issue: the list of pages on the right does not necessary include the startpages on the left, it might be more logical to include them as well so they can be removed from startpages from there as well as the others done

boogheta commented 4 years ago

I'm not too worried about the problematic scenario, it might be annoying on the demo, but having a ma depth of 1 the user would still need to go back and forth so I don't think it would be too much of an issue.

But I agree the "remove all" button would be a bit weird. Although I feel like it is necessary for when someone used the selectAll by mistake and it is not too critical.

So I feel like we should do it, and it shouldn't be too complex (but I need to add API routes to allow adding/removing multiple startpages at once before or it would be overkill calling the API so many times)

@jacomyma I feel like the good place for such buttons would be within the "Startpages" tab at the top or the bottom, what do you think?

jacomyma commented 4 years ago

I agree with your analysis. I think the logical place is on top of the list; that is where I would search for this feature (see image below).

button place

jacomyma commented 4 years ago

Additional remark: the buttons may take place, as you suggest, in the "start pages" tab, if we wish to semi-hide / disincentivize them. Honestly, I am not against it.

boogheta commented 4 years ago

Yep, naturally I would do on top as you suggest, but I feel like needing two buttons with quite explicit text and considering the desire to avoid abuse of the feature, semi-hiding it within the startpages tab seems a good option :)

boogheta commented 4 years ago

(and I reintroduced already on top the search through pages feature (which triggers the collection of all pages not loaded yet when used) so that would be a bit heavy there)