fix ally.element.disabled to disable SVG links in Firefox

medialize / ally.js

JavaScript library to help modern web applications with accessibility concerns

http://allyjs.io/

MIT License

1.53k stars 83 forks source link

fix ally.element.disabled to disable SVG links in Firefox #133

Closed rodneyrehm closed 8 years ago

rodneyrehm commented 8 years ago

Since Firefox does not support the tabindex and focusable attributes on SVG content, links <a xlink:href="..."> were not properly removed from the tabbing order. While not availble to the mouse, one could Tab to these links.

This PR fixes that problem by removing (and restoring) the xlink:href attribute.

coveralls commented 8 years ago

Coverage increased (+0.009%) to 99.039% when pulling 454c6361fae549946a6d9b749ae19f3d00d2e159 on test/element-disabled into fb48917d1cc7350f14e914963379f32da094abcf on master.