medialize / ally.js

JavaScript library to help modern web applications with accessibility concerns
http://allyjs.io/
MIT License
1.53k stars 83 forks source link

Bootstrap Modal - ally.maintain.tabFocus #145

Closed joe-watkins closed 7 years ago

joe-watkins commented 7 years ago

Having an issue getting ally.maintain.tabFocus to work with Bootstrap 3.0 modal.

As you can see in this demo everything else appears to be working but not able to handle tab shift-tab to keep focus out of UI.

Bootstrap offers open and close events to hook onto shown.bs.modal and hidden.bs.modal.

Any ideas why this isn't working?

http://codepen.io/joe-watkins/pen/RWzmjJ

rodneyrehm commented 7 years ago

ally.maintain.tabFocus was added in version 1.1.0, but your pen was using version 1.0.1. I've forked your pen and upraded it to v1.1.1 - works fine for me.

joe-watkins commented 7 years ago

@rodneyrehm you rock! Thanks for your work on this tool.