search

mediamicroservices / mm

MIT License
68 stars 27 forks source link

added streamable #291

Closed metacynicv2 closed 2 years ago

metacynicv2 commented 2 years ago

fixed I think...

On Thu, Mar 24, 2022 at 11:58 AM Dave Rice @.***> wrote:

@.**** commented on this pull request.

In makederiv https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mediamicroservices_mm_pull_291-23discussion-5Fr834471272&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=j095mgBqNgHRwp0uxgGyeA&m=6_dQRZLlq8T5MY199SliQWimhUafaHXn8-97YuEBDuq3Mc-s0UAqPUbZKa1AGima&s=I3uKIfjslYDG2wCN0hsZS9E2O1jjb2N8wso7bjZ2ylU&e= :

@@ -520,6 +525,17 @@ while [[ "${@}" != "" ]] ; do _add_video_filter "crop=720:480:0:32" fi _add_video_filter "yadif"

  • elif [[ "${OUTPUT_TYPE}" == "streamable" ]]; then
  • MIDDLEOPTIONS+=(-movflags faststart)
  • MIDDLEOPTIONS+=(-pix_fmt yuv420p)
  • MIDDLEOPTIONS+=(-c:v libx264)
  • MIDDLEOPTIONS+=(-c:a aac)

can you move the audio stuff to the later audio section and neaten the mixed indentation methods (4 spaces preferred)

— Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mediamicroservices_mm_pull_291-23pullrequestreview-2D920504055&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=j095mgBqNgHRwp0uxgGyeA&m=6_dQRZLlq8T5MY199SliQWimhUafaHXn8-97YuEBDuq3Mc-s0UAqPUbZKa1AGima&s=UyiDdk-cs-m3fy2eezZjJRdSfGvPCy8bWYdv_iyHUm8&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ACH7YUMHCA36JJH56BFBIMDVBSGKHANCNFSM5RRSJ2OA&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=j095mgBqNgHRwp0uxgGyeA&m=6_dQRZLlq8T5MY199SliQWimhUafaHXn8-97YuEBDuq3Mc-s0UAqPUbZKa1AGima&s=a28g28-KxCmiDh4YII3_7oyeiHtqQHVH6xv0YMdvXdU&e= . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Kelly Haydon Adjunct Professor Moving Image Archiving and Preservation Tisch School of the arts Email: @.***

Bring justice and equity to Black, Indigenous, and People of Color (BIPOC) communities.

New York University is located on the ancestral lands of the Lənape Haki-nk, of the Delaware Tribe of Indians http://delawaretribe.org/, a proud and sovereign nation whose commitment to culture, community, and land stewardship persist in the face of ongoing settler colonialism. she/her/hers