mediamonks / frontend-coding-standards

Media.Monks - Frontend Coding Standards
60 stars 23 forks source link

Add default tsconfig.json #11

Open ThaNarie opened 4 years ago

ThaNarie commented 4 years ago

To align between all our skeletons, easily setup up other projects, and to align with our other standards, it would be good to define a "default" tscofig.json.

I think we can use use an existing one (from muban or vue-skeleton), and tweak it a bit.

Feel free to add to this list of "musts" or "discussion points":

skulptur commented 4 years ago

shouldn't noUnusedParameters be true for it to complain about unused code?

skulptur commented 4 years ago

noImplicitAny is true if strict is true. But how about we start from a tsconfig that lists every option and we explicitly set everything ourselves to make it obvious rather than relying on TS defaults and flags that affect other flags?

skulptur commented 4 years ago

https://github.com/mediamonks/frontend-coding-standards/pull/12

gianko commented 4 years ago

~related (maybe?), and for VSCode~

~https://code.visualstudio.com/docs/languages/jsconfig~

not needed if theres a tsconfig

https://code.visualstudio.com/docs/nodejs/working-with-javascript#_migrating-to-typescript